Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh button should load using accessed URL not typed URL #62

Closed
KyGost opened this issue Oct 10, 2020 · 4 comments
Closed

Refresh button should load using accessed URL not typed URL #62

KyGost opened this issue Oct 10, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@KyGost
Copy link
Member

KyGost commented Oct 10, 2020

If user types a URL in the URL bar and then abandons it and later clicks refresh, the URL typed will be the URL loaded.

In other browsers and, perhaps, the expected behaviour is for the current page/URL to refresh and perhaps the URL bar to fresh to its accessed URL.

@RangerMauve RangerMauve added the bug Something isn't working label Oct 14, 2020
@RangerMauve
Copy link
Member

I think there's two ways we can approach this:

  • Spit the refresh/go button into two buttons (this is what most browsers do)
  • When you de-focus the omni-box, it should revert to whatever the current URL is
  • Something else

@RangerMauve RangerMauve added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 14, 2020
@KyGost
Copy link
Member Author

KyGost commented Oct 15, 2020

I feel like the defocus could be a good solution.
One would need to have a go with it first and see if it feels odd/bad though.

@jolindroth
Copy link
Contributor

jolindroth commented Dec 28, 2021

I think we can reuse the custom event from #139. Currently the event is only fired when we press the ESC-button, but if we can make it fire on focusing the BrowserView/WebContents I think we will get the behaviour we want.
May require some workarounds since there's no native support for focus events of BrowserView/WebContents in electron yet: electron/electron#25873

@RangerMauve
Copy link
Member

I think the UX after @jolindroth 's fix in #139 makes this usable. Basically, after we navigate away the URL bar gets reset so you can reload normally again. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants