Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add components class (fix #203) #337

Merged
merged 3 commits into from Oct 20, 2022
Merged

feat: add components class (fix #203) #337

merged 3 commits into from Oct 20, 2022

Conversation

hugoattal
Copy link
Collaborator

Fix #203

Description

I just added histoire-[component name in snake case] to every relevant component.

  • I didn't want to use the htw- prefix to differentiate it from the tailwind classes
  • I still think we need a prefix to prevent CSS leaking

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal self-assigned this Oct 19, 2022
@stackblitz
Copy link

stackblitz bot commented Oct 19, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit c1c83fa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/63508d3ccea4cc00081e6a34
😎 Deploy Preview https://deploy-preview-337--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit c1c83fa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/63508d3c5271e00008b95253
😎 Deploy Preview https://deploy-preview-337--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit c1c83fa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/63508d3c69e9d1000b151d45
😎 Deploy Preview https://deploy-preview-337--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit c1c83fa
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/63508d3c661aa000091c893a
😎 Deploy Preview https://deploy-preview-337--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugoattal hugoattal requested a review from Akryum October 19, 2022 23:50
@Akryum Akryum merged commit c85126e into main Oct 20, 2022
@Akryum Akryum deleted the add-compoments-class branch October 20, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom styles on Histoire UI
2 participants