New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: StoryResponsivePreview vertical resize #704
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Do you have an example story that exhibit this behavior? |
It doesn't depends of the story but how the css is construct and ordered on https://controls.histoire.dev/story/histoire-controls-src-components-checkbox-hstcheckbox-story-vue?variantId=histoire-controls-src-components-checkbox-hstcheckbox-story-vue-0 if you try to resize vertically the story, the window of the story will keep the full height If you look at the css of the problematic div : removing the htw-h-full class doesn't seems to cause any problem and fix the issue |
Description
fix the preview that could not being visually resized vertically.
it's a problem that could not appear because two rules have equals css specificity.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).