Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StoryResponsivePreview vertical resize #704

Merged
merged 1 commit into from Apr 2, 2024

Conversation

Mobyrr
Copy link
Contributor

@Mobyrr Mobyrr commented Mar 27, 2024

Description

fix the preview that could not being visually resized vertically.

it's a problem that could not appear because two rules have equals css specificity.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Mar 27, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 98dbb2d
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/660428ad273e570008e2540f
😎 Deploy Preview https://deploy-preview-704--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 98dbb2d
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/660428ade70d6e00088ad709
😎 Deploy Preview https://deploy-preview-704--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 98dbb2d
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/660428adf4f671000820c334
😎 Deploy Preview https://deploy-preview-704--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 98dbb2d
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/660428ad1a7010000885cc3d
😎 Deploy Preview https://deploy-preview-704--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akryum
Copy link
Member

Akryum commented Mar 27, 2024

Do you have an example story that exhibit this behavior?

@Mobyrr
Copy link
Contributor Author

Mobyrr commented Mar 27, 2024

It doesn't depends of the story but how the css is construct and ordered

on https://controls.histoire.dev/story/histoire-controls-src-components-checkbox-hstcheckbox-story-vue?variantId=histoire-controls-src-components-checkbox-hstcheckbox-story-vue-0 if you try to resize vertically the story, the window of the story will keep the full height

If you look at the css of the problematic div :
image
(theses selectors have the same specificity of (0, 1, 0))

removing the htw-h-full class doesn't seems to cause any problem and fix the issue

@Akryum Akryum merged commit de8f4b3 into histoire-dev:main Apr 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants