VideoView should be returning the src respecting the dragonfly's datastore's configuration

[mediazard]

First of all, thank you for the amazing CMS engine you've created.

Currently the VideoView is returning for the src the show_attachment_path.
I'm wondering what are the reasons for not using the datastore to generate the url as it already happening with the PictureView.
Having the possibility to get the video served from the CDN directly would be beneficial I think.

Thanks

[tvdeyen]

It returns the url to whatever datastore you have configured. The default is the local file system. What datastore have you configured?

[mediazard]

well this is the datastore's config:

Dragonfly.app(:alchemy_attachments).configure do
  datastore :s3,
            bucket_name: ENV.fetch('S3_ATTACHMENTS_BUCKET_NAME', nil),
            access_key_id: ENV.fetch('S3_ACCESS_KEY_ID', nil),
            secret_access_key: ENV.fetch('S3_ACCESS_KEY_SECRET', nil),
            use_iam_profile: ENV['S3_ACCESS_KEY_ID'].blank?,
            region: ENV.fetch('S3_REGION', nil),
            url_host: ENV.fetch('S3_ATTACHMENTS_URL_HOST', nil),
            url_scheme: 'https'
end

but the VideoView is returning the path pointing to the attachments_controllers#show as per https://github.com/AlchemyCMS/alchemy_cms/blob/main/app/components/alchemy/ingredients/video_view.rb#L18-L23

am I missing something ?
On my side I've simply patched the VideoView#src with

def src attachment.url end