Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not disable Global Media Control any longer #657

Open
Banderi opened this issue May 1, 2024 · 7 comments
Open

Can not disable Global Media Control any longer #657

Banderi opened this issue May 1, 2024 · 7 comments

Comments

@Banderi
Copy link

Banderi commented May 1, 2024

System Details

  • OS: Windows 10
  • Thorium Version 123.0.6312.133 64-bit

Problem
I used to use the --disable-features=GlobalMediaControls flag on the startup shortcut to disable the Global Media Controls panel. Unfortunately, this no longer seems to work with the recent update. The #global-media-controls-updated-ui flag in the settings (and any other) also does not remove the button.

Screenshots
image

Additional Notes
I've tried to browse through the source for more insight on how the --disable-features= flag is parsed, and understand why it no longer works, however I can't seem to find anything regarding this in the source. I see some sporadic references to kEnableFeatures but that also doesn't seem actually used anywhere. The only file where that is used is a browser test .cc that makes references to various missing files such as content/shell/common/shell_switches.h. What is going on here?

@gz83
Copy link
Collaborator

gz83 commented May 2, 2024

Does the 123 version of Chrome or Chromium have the same problem?

@Alex313031
Copy link
Owner

@Banderi Try also disabling GlobalMediaControlsUpdatedUI

@Banderi
Copy link
Author

Banderi commented May 3, 2024

@Banderi Try also disabling GlobalMediaControlsUpdatedUI

I tried disabling that flag as well as hardware-media-key-handling and enable-web-app-system-media-controls-win and other combinations from comments I found on the net but I couldn't get it to work sadly.

Do you know perhaps where in the code the --disable-features= flags are parsed? I can't find it anywhere and the Chromium src search on github is bugged (stuck on indexing)

@Alex313031
Copy link
Owner

@Banderi Use the source code search for Chromium here > https://source.chromium.org/chromium

Most of these features are controlled by this file > https://source.chromium.org/chromium/chromium/src/+/main:media/base/media_switches.cc

@Banderi
Copy link
Author

Banderi commented May 6, 2024

@Banderi Use the source code search for Chromium here > https://source.chromium.org/chromium

Most of these features are controlled by this file > https://source.chromium.org/chromium/chromium/src/+/main:media/base/media_switches.cc

Ok, I think I understand my confusion now. I couldn't figure out why the searches weren't returning anything, and after looking through the source I couldn't figure out why there was whole sections missing from the folders. Now I realize that this fork doesn't include the Chromium source in its entirety, and requires third party tools to fetch the rest (depot_tools).
Also, there isn't a single file that tailors and lists all the feature flags recognized by Chromium as I initially assumed, instead the BASE_FEATURE(...) command is invoked in the files that pertain to those features (e.g. kGlobalMediaControls inside media_switches.cc) and there it is initialized and recorded to the engine. (This command and its internals are defined in the Chromium source but not in the fork since they haven't been touched.)

I'm gonna try to look now at the source directly now and see if anything changed with the usage of the kGlobalMediaControls flag and why it's not working on my end...

@Nicols0Mart
Copy link

I'm using latest build from today and this is still broken on windows release. Disabling the flag #global-media-controls-updated-ui does not remove the icon when playing a video in YouTube for example

@Alex313031
Copy link
Owner

@Nicols0Mart @Banderi Yeah, it still doesn't seem to be able to be disabled, even with --disable-features=GlobalMediaControls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants