Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Am I crazy, or are the icons missing from forms? #126

Open
nlfiedler opened this issue Nov 16, 2018 · 3 comments
Open

Am I crazy, or are the icons missing from forms? #126

nlfiedler opened this issue Nov 16, 2018 · 3 comments

Comments

@nlfiedler
Copy link

nlfiedler commented Nov 16, 2018

Look at https://bloomer.js.org/#/documentation/elements/form in a recent version of any major browser and you should see that the icons are missing from the form fields. When did this start happening? I've noticed it for a while, but couldn't decide if it was just my imagination or a fluke. It's also not working in my own project. In my code, I have this:

<Icon isSize='small' isAlign='left'><span className='fa fa-quote-left' /></Icon>

Which turns into this:

<span class="icon is-left is-small"><i class="undefined" aria-hidden="true"></i></span>

I'm no expert, but I think that's wrong. I'm using babel 6.23 and babel-preset-react 6.24.1, and can provide other details as needed.

@LinuCC
Copy link

LinuCC commented Nov 18, 2018

Got the same problem.
After a long session of bisecting I've found the issue to be the upgrade from 0.6.3 to 0.6.5 , something in there broke the rendering of either react-fontawesome or @fortawesome/fontawesome-svg-core.

@nlfiedler
Copy link
Author

The good news is, for simple cases, you can just move the className to the Icon element and skip the inner element altogether.

@indrabinridwan
Copy link

yeah i've same problem +

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants