Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Add File Upload to Forms #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add File Upload to Forms #106

wants to merge 4 commits into from

Conversation

aszecsei
Copy link

@aszecsei aszecsei commented Jul 6, 2018

This resolves #97 and adds a collection of the File Upload elements that Bulma uses, documented here.

I had unrelated issues getting the documentation to build (#105), so there may be some problems with my additions for that.

@coveralls
Copy link

coveralls commented Jul 6, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling cad72bb on aszecsei:add-file-upload into 0ab9c67 on AlgusDark:master.

@AlgusDark AlgusDark self-requested a review July 14, 2018 04:15
AlgusDark
AlgusDark reviewed Sep 6, 2018
View reviewed changes
Copy link
Owner

@AlgusDark AlgusDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Maybe you can open docs/src/Components/NavBar.tsx and make a change from export default withRouter<{}>(NavBar); to export default withRouter(NavBar);

Maybe that would solve the docs problem.

@lveillard
Copy link

Having this would be awesome 🚀

@aszecsei
Copy link
Author

@AlgusDark unfortunately changing that didn't affect the docs building - there are a ton of errors I'm getting from files I didn't touch, like

    TS1013: A rest parameter or binding pattern may not have a trailing comma.

Those are easy enough to solve, but then there are ones like

    TS2322: Type '{ className: string; accept?: string; acceptCharset?: string; action?: string;
allowFullScreen?: ...' is not assignable to type 'DetailedHTMLProps<TextareaHTMLAttributes<HTMLTextAreaElement>, HTMLTextAreaElement>'.
  Type '{ className: string; accept?: string; acceptCharset?: string; action?: string; allowFullScreen?: ...' is not assignable to type 'ClassAttributes<HTMLTextAreaElement>'.
    Types of property 'ref' are incompatible.
      Type 'Ref<HTMLElement>' is not assignable to type 'Ref<HTMLTextAreaElement>'.
        Type 'RefObject<HTMLElement>' is not assignable to type 'Ref<HTMLTextAreaElement>'.
          Type 'RefObject<HTMLElement>' is not assignable to type 'RefObject<HTMLTextAreaElement>'.
            Type 'HTMLElement' is not assignable to type 'HTMLTextAreaElement'.
              Property 'autofocus' is missing in type 'HTMLElement'.

Honestly not even sure where to start trying to fix those 🙁

@AlgusDark
Copy link
Owner

@aszecsei I don't have Internet right now (until end of the month I will have). I'll check and make changes on Master branch 🤔

This project needs to get some updates from TS. After that, we shouldn't have any problems.

First of all, thanks for this. Please let's wait for my chages 🙏 so sorry.

@enessoylu
Copy link

@AlgusDark Are you planning to merge this? :)

@arthurkhlghatyan
Copy link

Hi Guys,

Anyone working on this?

I don't see the file upload input in the list of available form elements.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlgusDark AlgusDark AlgusDark left review comments

@enessoylu enessoylu enessoylu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Add File Upload element to Forms
6 participants
@aszecsei @coveralls @lveillard @AlgusDark @enessoylu @arthurkhlghatyan