Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading theme affects all open instances #244

Open
dnjackson opened this issue Mar 14, 2024 · 1 comment
Open

Loading theme affects all open instances #244

dnjackson opened this issue Mar 14, 2024 · 1 comment

Comments

@dnjackson
Copy link
Contributor

When I load a theme, it seems to update the display of all open visualization instances. I don't recall this being the behavior, and I wonder if it's a regression. It's especially annoying when you have instances open from different models because then they really get messed up.

@nmacedo
Copy link
Contributor

nmacedo commented Mar 28, 2024

Looking at the code it seems that it was always the case (there's really just one instance loaded at all times, when you close the current instance it just re-loads the previous one with the current theme).

When themes are loaded from .thm files it should be easy to keep track of the .thm associated with each instance and reload when needed. Keeping track of theme customisations not stored in a .thm is going to be more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants