feat: headless modal sample #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
from
58f55b8
to
d50881d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
- Coverage 93.47% 84.37% -9.10%
==========================================
Files 67 48 -19
Lines 2099 1927 -172
Branches 379 355 -24
==========================================
- Hits 1962 1626 -336
- Misses 73 219 +146
- Partials 64 82 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
from
d50881d
to
a07eef5
Compare
quentinderoubaix
requested review from
divdavem,
fbasso,
andreascorti,
ExFlo,
MarkoOleksiyenko and
ValentinNelu
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
4 times, most recently
from
ddbe7dd
to
d7ae0d4
Compare
divdavem
reviewed
May 29, 2024
divdavem
reviewed
May 29, 2024
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
from
d7ae0d4
to
2e8abe7
Compare
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
from
2e8abe7
to
4697cc0
Compare
quentinderoubaix
force-pushed
the
746-headless-sample-with-modal
branch
from
4697cc0
to
6ebcbce
Compare
divdavem
approved these changes
May 29, 2024
|
thx for the review @divdavem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #746