Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withCredentials can be provided directly in options #47

Open
naugtur opened this issue May 29, 2015 · 3 comments
Open

withCredentials can be provided directly in options #47

naugtur opened this issue May 29, 2015 · 3 comments

Comments

@naugtur
Copy link
Member

naugtur commented May 29, 2015

xhr supports withCredentials option for a while now and the docs describing aompersand-sync should not say that you need xhrFields to add withCredentials as a typical case.

(help me find the file and I can PR it)

@naugtur
Copy link
Member Author

naugtur commented Aug 2, 2015

There's been much more changes since I created this issue...
Thanks for pointing to those.
I see other modules are documented in READMEs so it's probably best to doscument sync in its README first, and then fill in the above.

@pgilad
Copy link
Member

pgilad commented Aug 2, 2015

Yeah I agree.. Although a lot of the ajaxConfig are similar between any module that relies on &-sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants