Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide multi-select actions not applicable to the current selection #7157

Open
4 tasks done
ByteHamster opened this issue May 1, 2024 · 0 comments
Open
4 tasks done
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request

Comments

@ByteHamster
Copy link
Member

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

develop

Where did you get the app from

Google Play

Problem you may be having, or feature you want

When starting multi-select, AntennaPod shows both "mark as played" and "mark as unplayed" even if all selected episodes are unplayed. This looks a bit weird. Especially if we want to use that menu even for single-select at some point.

Suggested solution

Hide the actions that are not relevant to the current selection

Screenshots / Drawings / Technical details

Note that the current selection might be very large, especially with lazy loading. When "select all" or "select all below" was pressed (see SelectableAdapter.shouldSelectLazyLoadedItems), we should show all actions. Maybe even when a large number of items is selected, so that we don't need to loop over a huge number of items checking their attributes.

@ByteHamster ByteHamster added Type: Feature request Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request
Projects
None yet
Development

No branches or pull requests

1 participant