Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the Polly and Polly.Specs codebase #1290

Open
martintmk opened this issue Jun 14, 2023 · 2 comments
Open

Cleanup the Polly and Polly.Specs codebase #1290

martintmk opened this issue Jun 14, 2023 · 2 comments
Labels
enhancement Hacktoberfest Suggested contribution for Hacktoberfest help wanted A change up for grabs for contributions from the community up-for-grabs

Comments

@martintmk
Copy link
Contributor

In the #1287 we enabled a full set of analyzers for these projects. Many of the rules are currently suppressed in each respective csproj file with the <NoWarn> element.

We can enable these rules one-be-one and cleanup the codebase.
@martincostello martincostello added the help wanted A change up for grabs for contributions from the community label Jun 16, 2023
@martintmk martintmk mentioned this issue Jul 11, 2023
Closed
@IgorIgorevich94 IgorIgorevich94 mentioned this issue Aug 24, 2023
Merged
4 tasks
IgorIgorevich94 added a commit to IgorIgorevich94/Polly that referenced this issue Aug 26, 2023
@IgorIgorevich94
Brought back a condition check in the lock (App-vNext#1290)
d8ccdd8
IgorIgorevich94 added a commit to IgorIgorevich94/Polly that referenced this issue Aug 28, 2023
@IgorIgorevich94 @martincostello
Apply suggestions from code review (App-vNext#1290)
2c49df8 
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello added the Hacktoberfest Suggested contribution for Hacktoberfest label Sep 28, 2023
@davidCett
Copy link

Hi👋I would like to help with this issue

@martincostello
Copy link
Member

@davidCett Thanks for volunteering! Feel free to open a pull request to tackle one of the disabled warnings. I suggest you tackle one or two per pull request to prevent the diffs getting too big to easily review.

@davidCett davidCett mentioned this issue Oct 4, 2023
Closed
4 tasks
This was referenced Jan 26, 2024
Merged
Merged
Merged
@gintsk gintsk mentioned this issue Jan 27, 2024
Merged
4 tasks
This was referenced Jan 28, 2024
Merged
Merged
@gintsk gintsk mentioned this issue Feb 3, 2024
Merged
4 tasks
@baranyaimate baranyaimate mentioned this issue Feb 4, 2024
Merged
4 tasks
@gintsk gintsk mentioned this issue Feb 4, 2024
Merged
4 tasks
@baranyaimate baranyaimate mentioned this issue Feb 6, 2024
Merged
4 tasks
This was referenced Feb 8, 2024
Merged
Merged
Merged
@gintsk gintsk mentioned this issue Feb 18, 2024
Merged
4 tasks
This was referenced Mar 3, 2024
Merged
Merged
This was referenced Mar 15, 2024
Merged
Merged
@cbredlow cbredlow mentioned this issue Mar 26, 2024
Closed
4 tasks
This was referenced Apr 25, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced May 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest Suggested contribution for Hacktoberfest help wanted A change up for grabs for contributions from the community up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martincostello @davidCett @martintmk