Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Option to not show notifications icon, when there isnt any notification #4847

Open
inson1 opened this issue Mar 7, 2024 · 4 comments · May be fixed by #5302
Open

[FR] Option to not show notifications icon, when there isnt any notification #4847

inson1 opened this issue Mar 7, 2024 · 4 comments · May be fixed by #5302
Labels
desktop good first issue for devs for the community members to claim improvements improvements on an existing feature look and joy

Comments

@inson1
Copy link

inson1 commented Mar 7, 2024 •
edited

Description

I dont use notification, so its just cluttering my screen

Impact

Users, who dont use notifications or at least not often

Additional Context

I think its better option than not showing it at all, because what if?
@Xazin Xazin added good first issue for devs for the community members to claim improvements improvements on an existing feature desktop look and joy labels Mar 7, 2024
@emmggi
Copy link

emmggi commented Mar 7, 2024 •
edited

Notifications have reminders. Also how much of a clutter is it to have a single additional button in a panel that can be hidden? I don't think we should remove it. It's an integral part of the app.

@inson1
Copy link
Author

inson1 commented Mar 7, 2024 •
edited

@emmggi I just meant option for this in settings, I dont see anything bad with that.

Panel can be hidden, button cant be hidden, for that is this FR

@ahsanfarooq210
Copy link

ahsanfarooq210 commented Mar 18, 2024 •
edited

Hi there. I want to solve this issue. A little detail would be helpful.
pleas assign this issue to me

@inson1
Copy link
Author

inson1 commented Mar 18, 2024

@ahsanfarooq210 I dont think you need to be assign, just try to create the PR

@migcarde migcarde linked a pull request May 9, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
desktop good first issue for devs for the community members to claim improvements improvements on an existing feature look and joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: integrate show notification button option migcarde/AppFlowy
4 participants
@Xazin @emmggi @ahsanfarooq210 @inson1