6.14.3 breaking android change

[CTOverton]

Report

There seems to be an update made for the sdk that conflicts with android and react native android side of things. @swrobel provided more details here #546 (comment)

The affected pr is here #546

Plugin Version

6.14.3

On what Platform are you having the issue?

Android

What did you do?

1. Update react-native-appsflyer to 6.14.3
2. Build react native app for Android

Notice gradle will fail to build with this error:

Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:26:9-36
	is also present at [com.appsflyer:af-android-sdk:6.14.0] AndroidManifest.xml:32:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

What did you expect to happen?

Android to successfully build

What happened instead?

Android failed to build

[swrobel]

In order to fix this, I set android:allowBackup="true" in AndroidManifest.xml. I don't see any harm in changing this setting; it seems to have been set as a default years ago in RN without any explanation. Someone questioned the choice of false as a default, but no explanation was ever provided. Honestly, true sounds better for user experience.

[CTOverton]

Thanks @swrobel, is this something that will be fixed in the future so this step won't be necessary? Or will this need to be added to the setup documentation for appsflyer?

[swrobel]

Beats me... I'm just a user like you 🤷🏼‍♂️

[TomasSestak]

this is definetely bug
allow_backup = false must be usable

[mblarsen]

We need allowBackup to be false too. It is not an option for us to enable backups.

I've opened an issue on the Android repo AppsFlyerSDK/appsflyer-android-sdk#70 which is where the setting comes from.

cc @TomasSestak please upvote the issue