Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-F Toggle Safety Switch should be two separate buttons #3268

Open
rmackay9 opened this issue Jan 4, 2024 · 1 comment
Open

Ctrl-F Toggle Safety Switch should be two separate buttons #3268

rmackay9 opened this issue Jan 4, 2024 · 1 comment

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Jan 4, 2024

We've had at least one user crash caused by the user "toggling" the safety switch and losing control of the vehicle when they wanted to enable movement of the servos (e.g. safety switch disabled?).

To make it safer we should replace the toggle with two buttons.
image

We should also check that the button specifies the target system id of the vehicle selected in the Connect drop-down on the main screen.

Related issue #3124

@ROSStargh
Copy link

Very approving.

#2987

#3269

I've experienced a crash 2 years ago when toggling safety switch under control-F. Multiple drones were connected to GCS. One was in the air, and the others were on the ground. I was trying to take off another drone.

There was no obvious indicator that shows the state of the safety switch. And the command had effect on every drone on the link. So I had no idea all drones had their safety switch already disabled.

It looks like the cause is that the command was sent to target_system=0.

4ec17ff6093a8556ff89373586f7628a095af31d.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants