Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter Comparison Issues: Should be within FLT_ESPSILON is the same #3284

Open
hendjoshsr71 opened this issue Feb 4, 2024 · 2 comments
Open

Parameter Comparison Issues: Should be within FLT_ESPSILON is the same #3284

hendjoshsr71 opened this issue Feb 4, 2024 · 2 comments
Assignees
@hendjoshsr71

Comments

@hendjoshsr71
Copy link
Member

hendjoshsr71 commented Feb 4, 2024 •
edited

  • Parameter comparison should be a float epsilon comparison

image

  • The screen should show parameters not found during the comparison on either the vehicle side or the file side as "Not found" or "N/A". (See QGC)

  • Add checkbox to remove Read Only params from the comparison

  • Check comparison feature doesn't break when ingesting a param file with lots of comments
@hendjoshsr71
Copy link
Member Author

I guess i don't have rights to this repo to assign myself :)

@robertlong13
Copy link
Collaborator

These are excellent suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hendjoshsr71 hendjoshsr71

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertlong13 @hendjoshsr71