Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish repositories.json as separate npm package: eslint-remote-tester-repositories #71

Closed
AriPerkkio opened this issue Apr 19, 2021 · 1 comment · Fixed by #77
Closed
Assignees

Comments

@AriPerkkio
Copy link
Owner

Context: jsx-eslint/eslint-plugin-react#2963 (comment). Same issue has come up earlier with two other plugins.

What

Provide easy way for plugin projects to get repositories for their eslint-remote-tester.config.js. A simple entrypoint for array of repositories would be enough.

// eslint-remote-tester.config.js
const repositories = require('eslint-remote-tester-repositories');

module.exports = {
   repositories: repositories.filter(repository => repository !== 'org/some-repository-which-we-dont-want'),
   ...
}

Maybe export the pathIgnorePattern too?

How

New directory for this package in this repository:

lib
package.json // eslint-remote-tester's
repositories
├── index.js // entrypoint
├── repositories.json // Could be split into react-repositories.json, node-repositories.json, etc
└── package.json

Add new workflow for publishing eslint-remote-tester-repositories package.

@AriPerkkio
Copy link
Owner Author

cc. @MichaelDeBoey - similar concerns about maintaining repositories.json were discussed in eslint-plugin-testing-library project. This should solve those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant