Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent stack trashing #265

Closed
wants to merge 27 commits into from
Closed

Prevent stack trashing #265

wants to merge 27 commits into from

Conversation

SuperFola
Copy link
Member

Should close #250

Not ready for production

@github-actions github-actions bot added ark/compiler Related to the compiler ark/virtual machine Related to the ark virtual machine labels Jun 5, 2021
@SuperFola
Copy link
Member Author

The goal is to prevent this code from crashing the VM

(mut i 0)
(while (< i 10000) {
  1
  (set i (+ 1 i))
})

@SuperFola
Copy link
Member Author

This could be handled by the optimizer, through an internal keyword Pop, so that the compiler only needs to add a POP instruction after compiling a (Keyword::Pop code).

This is only moving the problem away, but I think it can make the code better

@SuperFola SuperFola added this to the 3.1.0 milestone Jun 12, 2021
@SuperFola
removing the m_holders member in the compiler
180d9bf
@SuperFola
adding basic code needed for detecting and preventing stack trashing …
e1be639 
…in the compiler
@SuperFola
adding basic algorithm for isTerminalNode and isCurrentNodeStored
9cf3a45
@SuperFola
a node can be stored if it's a terminal node in a if/store/function d…
a7820b8 
…efinition/function call
@SuperFola
moving inline compiler methods in Compiler.inl
8345ea7
@SuperFola
if we don't have anything in the history, the node can not be stored
70e6730
@SuperFola
we need to have access to the parent node
e77d58e
@SuperFola
fixing namespaces in compiler.inl
a657b0b
@SuperFola
sending pointer to the parent node in the compiler
e1d7679
@SuperFola
sending position of the node in the parent
bce0a4a
@SuperFola
changing is_terminal test
a4be713
@SuperFola
begining of anti trashing
ce5a9ad
@SuperFola
removing the stack trashing detection/fix from the compiler, to try t…
051eee9 
…o put it in the optimizer
@SuperFola
trying a new idea to pop useless variables
68dff92
@SuperFola
wip: adding a visitor in the optimizer
5b4effb
@SuperFola
adding a depth parameter to our visitor
933bb09
@SuperFola
wip: adding flags when visiting a node
7911698
@SuperFola SuperFola linked an issue Jun 14, 2021 that may be closed by this pull request
Rewrite optimizer to have room for other optimizations #251
Open
@github-actions github-actions bot added the ark/parser Parser related label Jun 14, 2021
@SuperFola SuperFola self-assigned this Jun 14, 2021
@SuperFola SuperFola modified the milestones: 3.1.0, 3.2.0 Jun 29, 2021
@SuperFola SuperFola closed this Sep 29, 2021
@SuperFola SuperFola deleted the prevent-stack-trashing branch October 29, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SuperFola SuperFola

Labels
ark/compiler Related to the compiler ark/parser Parser related ark/virtual machine Related to the ark virtual machine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite optimizer to have room for other optimizations Dump unused return values
1 participant
@SuperFola