Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font weight not generated with removeFallbacks plugin #18

Closed
fknop opened this issue Nov 25, 2020 · 6 comments
Closed

Font weight not generated with removeFallbacks plugin #18

fknop opened this issue Nov 25, 2020 · 6 comments

Comments

@fknop
Copy link

fknop commented Nov 25, 2020

With the removeFallbacks plugin, font-weight is not generated anymore since the update to tailwindcss 2.0 and xwind.

With the removeFallbacks plugin, twfont-bold emits an empty fontWeight object

@Arthie
Copy link
Owner

Arthie commented Nov 25, 2020

I wasn't able to reproduce this bug, can you provide more info?

Do you have babel caching enabled from babel-loader or next-babel-loader?
If so try manually deleting the cached babel files and rebuilding your project.

@fknop
Copy link
Author

fknop commented Nov 25, 2020

I'm using CRA which comes with babel and babel macros included.
I tried deleting node_modules/.cache but without success.
I'm gonna try to reinstall the entire node modules directory.

@fknop
Copy link
Author

fknop commented Nov 25, 2020

I tried deleting the node_modules directory but with no success.
For more info: CRA 3.4.3 + xwind/macro

@fknop
Copy link
Author

fknop commented Nov 25, 2020

It might be related to generated outputs being numbers. I tried with leading-none which generates 1. It didn't generate anything, however, leading-10 generates properly 2.5rem

@Arthie
Copy link
Owner

Arthie commented Nov 25, 2020

@fknop Thanks! I was able to reproduce the bug by creating a CRA project. I'm releasing a fix soon!
Yes, you are correct the fallback plugin didn't handle numbers correctly.

@Arthie
Copy link
Owner

Arthie commented Nov 26, 2020

@fknop should be fixed in the latest version (0.7.4)!
Don't forget to delete the node_modules/.cache again to get a clean build.
I recommend deleting the cache after tailwind.config.js changes or after updating packages until babel adds this PR to fix issue #8497.

@Arthie Arthie closed this as completed Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants