Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed contributors list from release drafter #241

Merged
merged 1 commit into from Mar 3, 2022

Conversation

ArtiomTr
Copy link
Owner

@ArtiomTr ArtiomTr commented Mar 3, 2022

This PR removes contributors list from the release-drafter.yml file.

There are several reasons, why I decided to do this:

  • Github recently added feature, which displays all people, who contributed to specific release.
  • There is an issue of all-contributors bot - when it modifies release-drafter.yml file, it looses identation, which corrupts .yml file, so I need manually fix indentation before each release.

With all that in mind, I think removing the list of contributors from release-drafter.yml is a reasonable decision. A list of all contributors will be at the end of the readme.md file.

@ArtiomTr ArtiomTr added the documentation Improvements or additions to documentation label Mar 3, 2022
@ArtiomTr ArtiomTr self-assigned this Mar 3, 2022
@ArtiomTr ArtiomTr merged commit 9ce24ef into main Mar 3, 2022
@ArtiomTr ArtiomTr deleted the Remove-contributor-list-from-release-drafter branch March 3, 2022 18:34
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/bin/git' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements 97.04% 754/777
🟢 Branches 94.44% 323/342
🟢 Functions 93.63% 147/157
🟢 Lines 96.85% 676/698

Test suite run success

153 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from 3d98807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant