New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Overwrite coverage report comment when a test fails #289
Comments
Hello @blordpluto 👋, Could you please attach your |
hello @ArtiomTr , not sure if I'm seeing exactly the same as described above, but I'm getting a new set of comments every time new commits are pushed to my PR. I've copied the job from our actions.yml as well as screenshots of the last 4 pushes that have each ended up with comments. Our actions run on The repo is private so I can't share it, but if you need more information please let me know. This is the job in my
below are screenshots from my last 4 pushes for one of the packages, (but each package is generating its own comment which is causing the PR to get really spammy): |
after looking at the source code I can see that since we are using the would it be possible to allow passing a edit proposed a solution here: #293 |
Hello @dalevfenton 👋, This action works with two event types: Could you please clarify, why you're using a |
Hi @ArtiomTr, I don't remember the details exactly but there are some differences about how and when a I've tested the code in PR #293 with our workflow and it is correctly able to associate with the pull request if passed the correct PR number as an input, so at least for our use-case it would be a very nice addition. I think I have tests passing so it would just need to have documentation updated at this point. |
Problem
When a commit causes a previously passing PR to fail a test, the old coverage comment remains. Since the default philosophy of the action seems to be to maintain and revise the coverage comment with the results of the latest run, it seems like it would make more sense to overwrite the comment with a message, something like:
Not a big deal, but I think this would be a better developer experience than leaving the stale comment.
The text was updated successfully, but these errors were encountered: