Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration loading #321

Merged
merged 4 commits into from Oct 21, 2022
Merged

Fix configuration loading #321

merged 4 commits into from Oct 21, 2022

Conversation

ArtiomTr
Copy link
Owner

This PR fixes #314.

Removed the cfgn configuration loader, which was using esbuild. Replaced with c12, a modern configuration loader used by popular tools like supabase, nuxt and others.

@ArtiomTr ArtiomTr added the bug Something isn't working label Oct 21, 2022
@ArtiomTr ArtiomTr self-assigned this Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
95.43% (-0.14% 🔻)
793/831
🟢 Branches
89.91% (+0.69% 🔼)
392/436
🟢 Functions
93.41% (-0.04% 🔻)
156/167
🟢 Lines
95.04% (-0.16% 🔻)
709/746
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / tryGetJestThreshold.ts
75% (-12.5% 🔻)
75% (+75% 🔼)
100%
71.43% (-14.29% 🔻)

Test suite run success

160 tests passing in 57 suites.

Report generated by 🧪jest coverage report action from 16cb1db

@ArtiomTr ArtiomTr merged commit 80c672b into main Oct 21, 2022
@ArtiomTr ArtiomTr deleted the Fix-configuration-loading branch October 21, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The esbuild JavaScript API cannot be bundled.
1 participant