Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of dynamic property warnings #118

Open
mtolhuys opened this issue Aug 24, 2023 · 6 comments · May be fixed by #119
Open

Creation of dynamic property warnings #118

mtolhuys opened this issue Aug 24, 2023 · 6 comments · May be fixed by #119

Comments

@mtolhuys
Copy link

The package has lots of dynamic property warnings f.e.

<warning> DEPRECATED </warning> Creation of dynamic property Asana\Client::$dispatcher is deprecated in vendor/asana/asana/src/Asana/Client.php on line 45.

Adding #[\AllowDynamicProperties] on these classes could solve this.
@mtolhuys mtolhuys linked a pull request Aug 24, 2023 that will close this issue
Open
@MichelleBlanchette
Copy link

MichelleBlanchette commented Sep 14, 2023 •
edited

I'm seeing these errors in PHP 8.2, as well. The error is on every resource type.

PHP Deprecated: Creation of dynamic property Asana\Resources\TimePeriods::$client is deprecated in /var/www/html/vendor/asana/asana/src/Asana/Resources/Gen/TimePeriodsBase.php on line 12

@MichelleBlanchette MichelleBlanchette mentioned this issue Sep 14, 2023
Closed
@mattinglot
Copy link

Would be awesome to see this fixed to get PHP 8.2 compatibility.

@mtolhuys
Copy link
Author

I'm seeing these errors in PHP 8.2, as well. The error is on every resource type.

PHP Deprecated: Creation of dynamic property Asana\Resources\TimePeriods::$client is deprecated in /var/www/html/vendor/asana/asana/src/Asana/Resources/Gen/TimePeriodsBase.php on line 12

Unfortunately there are also some warnings triggered by a dependency within this package (vendor/nategood/httpful) so not all will be solved by this.

@lnghost
Copy link

lnghost commented Sep 26, 2023

I'm seeing these errors in PHP 8.2, as well. The error is on every resource type.

PHP Deprecated: Creation of dynamic property Asana\Resources\TimePeriods::$client is deprecated in /var/www/html/vendor/asana/asana/src/Asana/Resources/Gen/TimePeriodsBase.php on line 12

Unfortunately there are also some warnings triggered by a dependency within this package (vendor/nategood/httpful) so not all will be solved by this.

This is a dead library, just change it to another one

@mtolhuys
Copy link
Author

I'm seeing these errors in PHP 8.2, as well. The error is on every resource type.

PHP Deprecated: Creation of dynamic property Asana\Resources\TimePeriods::$client is deprecated in /var/www/html/vendor/asana/asana/src/Asana/Resources/Gen/TimePeriodsBase.php on line 12

Unfortunately there are also some warnings triggered by a dependency within this package (vendor/nategood/httpful) so not all will be solved by this.

This is a dead library, just change it to another one

Still hoping for the merge but switching to fork if taking too long.

@MichelleBlanchette
Copy link

It's to the point where I'm concerned about using this PHP SDK at all now and considering just custom implementing the endpoints that I use in my projects. Did Asana drop support for this package?

@MichelleBlanchette MichelleBlanchette mentioned this issue May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@lnghost @mattinglot @mtolhuys @MichelleBlanchette