Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AssemblyScript/assemblyscript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.7
Choose a base ref
...
head repository: AssemblyScript/assemblyscript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.27.0
Choose a head ref
  • 4 commits
  • 25 files changed
  • 2 contributors

Commits on Jan 30, 2023

  1. Modernize issue templates

    @dcodeIO
    dcodeIO committed Jan 30, 2023
    Copy the full SHA
    5823c0e View commit details

  2. Check that builtins are implemented (#2636)

    @dcodeIO
    dcodeIO authored Jan 30, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e22a599 View commit details

Commits on Jan 31, 2023

  1. fix: Update this and return type in generated child class constructor (… 

    …#2635)
    @HerrCai0907
    HerrCai0907 authored Jan 31, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    941b0e1 View commit details

  2. Check global uses more strictly (#2632) 

    BREAKING CHANGE: Use of global variables (in the Wasm sense) is now checked more strictly to prevent undesirable execution order. If the compiler detects that it is possible that a variable might not have been initialized when accessed, a diagnostic is produced. It cannot be ruled out that some amount of existing code will be affected, since such checks are performed at runtime in JS but are proven at compile time in AS. If encountered, the fix is to move the variable's declaration up, say before the first invocation of a function (that might call another function) accessing the variable, so it is guaranteed that it is initialized before its first use.
    @dcodeIO
    dcodeIO authored Jan 31, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5cbbf84 View commit details
4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE.md
View file

This file was deleted.

33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Bug Report
description: Encountered an issue? File a bug report!
labels: [bug]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report! To get off to a good start, make sure to:
* Search if there is an existing issue on the topic
* Get familiar with the [contributing guidelines](https://github.com/AssemblyScript/assemblyscript/blob/main/CONTRIBUTING.md)
- type: textarea
id: description
attributes:
label: Bug description
description: What happened? What was the expected behavior?
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Steps to reproduce
description: |
How can the issue be reproduced? A minimum example is best. Tip: Use [code blocks](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks).
validations:
required: true
- type: input
id: version
attributes:
label: AssemblyScript version
description: "What's the AssemblyScript version used?"
placeholder: "vX.Y.Z"
validations:
required: true
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Feature suggestion
description: Got a neat idea? File a feature suggestion!
labels: [enhancement]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this feature suggestion! To get off to a good start, make sure to:
* Search if there is an existing issue on the topic
* See if the feature is mentioned at [implementation status](https://www.assemblyscript.org/status.html)
* Get familiar with the [contributing guidelines](https://github.com/AssemblyScript/assemblyscript/blob/main/CONTRIBUTING.md)
- type: textarea
id: description
attributes:
label: Feature suggestion
description: Please describe the feature you'd like to suggest.
validations:
required: true
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/question.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Ask a question
description: Wondering how to achieve something specific? Ask a question!
labels: [question]
body:
- type: markdown
attributes:
value: |
To get off to a good start, make sure to:
* Consider asking questions on our [community Discord](https://discord.gg/assemblyscript) instead
* Search if there is an existing issue on the topic
- type: textarea
id: description
attributes:
label: Question
description: What would you like to know?
validations:
required: true
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,9 @@
Thanks for submitting a pull request to AssemblyScript! Please take a moment to
review the contributing guidelines linked below, and confirm with an [x] 🙂
-->
Fixes # .

Changes proposed in this pull request:
⯈
⯈
⯈
Loading