Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AssemblyScript/assemblyscript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.27.24
Choose a base ref
...
head repository: AssemblyScript/assemblyscript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.27.25
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Mar 8, 2024

  1. fix: select correct override function (#2822)

    HerrCai0907 authored Mar 8, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    de174c5 View commit details
Showing with 4,472 additions and 3 deletions.
  1. +8 −1 src/compiler.ts
  2. +18 −2 src/module.ts
  3. +2,673 −0 tests/compiler/class-override.debug.wat
  4. +4 −0 tests/compiler/class-override.json
  5. +1,745 −0 tests/compiler/class-override.release.wat
  6. +24 −0 tests/compiler/class-override.ts
9 changes: 8 additions & 1 deletion src/compiler.ts
Original file line number Diff line number Diff line change
@@ -6618,6 +6618,7 @@ export class Compiler extends DiagnosticEmitter {
);
let overrideInstances = this.resolver.resolveOverrides(instance);
if (overrideInstances) {
let mostRecentInheritanceMapping = new Map<Class, Class>();
for (let i = 0, k = overrideInstances.length; i < k; ++i) {
let overrideInstance = overrideInstances[i];
if (!overrideInstance.is(CommonFlags.Compiled)) continue; // errored
@@ -6680,7 +6681,13 @@ export class Compiler extends DiagnosticEmitter {
if (instanceMembers && instanceMembers.has(instance.declaration.name.text)) {
continue; // skip those not inheriting
}
builder.addCase(extender.id, stmts);
if (
!mostRecentInheritanceMapping.has(extender) ||
!assert(mostRecentInheritanceMapping.get(extender)).extends(classInstance)
) {
mostRecentInheritanceMapping.set(extender, classInstance);
builder.addOrReplaceCase(extender.id, stmts);
}
}
}
}
20 changes: 18 additions & 2 deletions src/module.ts
Original file line number Diff line number Diff line change
@@ -3418,16 +3418,32 @@ export class SwitchBuilder {
this.condition = condition;
}

/** Links a case to the specified branch, replace old case if it is linked. */
addOrReplaceCase(value: i32, code: ExpressionRef[]): void {
const valueIndex = this.values.indexOf(value);
const codeIndex = this.addCode(code);
if (valueIndex >= 0) {
this.indexes[valueIndex] = codeIndex;
} else {
this.values.push(value);
this.indexes.push(codeIndex);
}
}

/** Links a case to the specified branch. */
addCase(value: i32, code: ExpressionRef[]): void {
this.values.push(value);
this.indexes.push(this.addCode(code));
}

private addCode(code: ExpressionRef[]): i32 {
let cases = this.cases;
let index = cases.indexOf(code);
if (index < 0) {
index = cases.length;
cases.push(code);
}
this.values.push(value);
this.indexes.push(index);
return index;
}

/** Links the default branch. */
2,673 changes: 2,673 additions & 0 deletions tests/compiler/class-override.debug.wat

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions tests/compiler/class-override.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"asc_flags": [
]
}
1,745 changes: 1,745 additions & 0 deletions tests/compiler/class-override.release.wat

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions tests/compiler/class-override.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
export function fn(n: i32): i32 {
return x.f(n);
}

class A {
f(a: i32): i32 {
return a + 1;
}
}
class B extends A {
f(a: i32): i32 {
return super.f(a) + 10;
}
}
class C extends B {
f(a: i32): i32 {
return super.f(a) + 100;
}
}
class D extends C {}

let x: A = new D();

assert(fn(0) == 111);