Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria-label being passed to header #377

Open
shaziajk opened this issue Jun 13, 2022 · 7 comments
Open

Aria-label being passed to header #377

shaziajk opened this issue Jun 13, 2022 · 7 comments

Comments

@shaziajk
Copy link

Hi @nihgwu @jamesonhill

Is there any way to currently pass down an aria-label in the props to the table?
In the current use case I have the table is being flagged for having accessibility issues as there is no programmatically associated name with the component

Thanks!

@nihgwu
Copy link
Contributor

nihgwu commented Jun 13, 2022

@shaziajk Sorry I'm afraid there is no such way to do that, it was built when I knew nothing about a11y

@jamesonhill
Copy link
Contributor

My company maintains a (private) fork for these things since Autodesk doesn't seem to be maintaining this anymore :(

@nihgwu
Copy link
Contributor

nihgwu commented Jun 13, 2022

@jamesonhill It's always me not Autodesk maintaining this library 😢 , I planned to work on a rewrite but I don't work with data anymore, and I was busy with other stuffs, so actually there is no effort on new features, but I'd say the current version is already good enough if you need to support IE11, and it's still used in Autodesk

I'd like to know what changes you have made, probably we can do something based on what you have

@jamesonhill
Copy link
Contributor

Ah, I see. I incorrectly assumed based on your comment & seeing no PRs merged that it was no longer maintained. The main thing we use the fork for is this fix: #334.

@nihgwu
Copy link
Contributor

nihgwu commented Jun 13, 2022

OK I'll take a look at your PR and try to land it soon, sorry I missed that

@jamesonhill
Copy link
Contributor

Thanks!

@shaziajk
Copy link
Author

Thank you for your replies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants