Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with category dropdown #1895

Open
MikeMorkes opened this issue Sep 27, 2019 · 1 comment
Open

Accessibility issue with category dropdown #1895

MikeMorkes opened this issue Sep 27, 2019 · 1 comment

Comments

@MikeMorkes
Copy link

Describe the bug
When running an accessibility audit on a wordpress page using the WP Job Manager shortcode "[jobs per_page="10" job_types="Full Time, Part Time, Temporary"]", the dropdown menu for Categories triggers a accessibility issue in the audit. Audit error message is:

Elements with [role] that require specific children [role]s, are missing.
Some ARIA parent roles must contain specific child roles to perform their intended accessibility functions.

Failing Elements
span.select2-selection.select2-selection--single

This element has aria-labelledby assigned to it, but it points to another element that doesn't exist on the page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to page using the shortcode.
  2. Open Dev Tools and run an audit.
  3. See error in audit summary.

Expected behavior
The element should either a) have its own aria-label, or b) the missing element needs to be put back in the html code with an appropriate label.

WordPress Environment

  • WordPress Version: 5.2.3
  • WP Job Manager Version: 1.33.5
  • PHP Version: tested with 5.6.4 and 7.3
@jom
Copy link
Member

jom commented Oct 1, 2019

Thanks for reporting this issue. We use Select2 for this behavior, which has some known accessibility issues. They started working on them in the latest release and I just updated the version included in the plugin (in the latest 1.34.0), but it looks like I still see some warnings.

PR with latest fixes select2/select2#5582
Master issue select2/select2#3735

WooCommerce supplements Select2's with its own augmented version. That might be necessary if more progress isn't made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants