Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @wordpress/i18n-text-domain Eslint rule #17091

Closed
simison opened this issue Sep 7, 2020 · 2 comments
Closed

Add @wordpress/i18n-text-domain Eslint rule #17091

simison opened this issue Sep 7, 2020 · 2 comments
Labels
Build [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Duplicate [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Sep 7, 2020

Is your feature request related to a problem? Please describe.

Add @wordpress/eslint-plugin which would give you a bunch of i18n related rules. Specifically you could ensure jetpack textdomain is always present for Gutenberg extensions.

Initially it could be defined in extensions's eslint config and once @wordpress/i18n is used elsewhere in Jetpack, at the root config.

See example:

https://github.com/Automattic/wp-calypso/blob/575477d44dd7d63f41031bc8216d822c12c16d9d/apps/editing-toolkit/.eslintrc.js#L5-L10

Additional context

See WordPress/gutenberg#20555
@simison simison added [Focus] i18n Internationalization / i18n, adaptation to different languages Build [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Sep 7, 2020
@jeherve
Copy link
Member

jeherve commented Sep 7, 2020

Closing as duplicate of #15374 and #16481

@jeherve jeherve closed this as completed Sep 7, 2020
@simison
Copy link
Member Author

simison commented Sep 7, 2020

Ahh! Thanks. Dunno why my searching failed so badly for this one. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Duplicate [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simison @jeherve