Correctly infer types on document arrays #12884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #12882.
The key insight here is that arrays of scalars and arrays of objects have different type inference logic. For example:
type: [{type: String, required: true}]
is an array of strings.type: [{type: "String", required: true}]
is also an array of strings.type: [{type: {foo: {type: String}, required: true}]
is an array of objects that contains a field namedtype
. Note here thattype
must be interpreted as a real key, not a type key.So if we have an array, we need to check if it's an array of scalars or objects. This is done as follows:
ObtainDocumentType
to make sure that its keys are interpreted correctly. (i.e. if the object has a key calledtype
, this is a real key, not a type key)Examples
Adds tests.