fix(types): handle Record<string, never>
as value for HydratedDocument TOverrides parameter
#13123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13094
Summary
I applied @hasezoey 's suggested fix for #13094. We can avoid
Record<string, never>
as a special case, because the only value that matches that is empty object{}
. But avoidingRecord<string, any>
orRecord<string, unknown>
is hard because it seems like any object extends fromRecord<string, any>
, and there's no good way to check if a type is a record type, or at least if a type is an object with known keys.I'm open to suggestions for better ways to fix this. But this should be enough to unblock.
Examples