Nested Discriminators in multi-dimensonal arrays use name instead of value

[hasezoey]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.10.1

Node.js version

19.6.0

MongoDB server version

5.0

Typescript version (if applicable)

4.9.5

Description

I have noticed that nested discriminator multi-dimensonal arrays use the name of the discriminator instead of value, like in non-array or one-dimensonal arrays

function parameter reference: path.discriminator(name, schema, value)

Steps to Reproduce

Reproduction Repository & branch: https://github.com/typegoose/typegoose-testing/tree/mongooseNestedDiscriminatorNaming

• (have node_modules install and a mongo instance running on default port)

• execute yarn run run (or any package manager)

• observe output being without the discriminated properties and assert error

• invert https://github.com/typegoose/typegoose-testing/blob/39da16a7de48d26f9d37b1ead010c0d7f48ce6ec/src/test.ts#L83-L88

• execute yarn run run (or any package manager)

• observe discriminated properties being present and no assertion error

also includes commented-out code for a one-dimensonal array

Expected Behavior

to use value like for one-dimensonal arrays and non-arrays

---

also tested mongoose 7.0.2, with same behavior

[hasezoey]

i think i found the reason:
SchemaArray does not pass-on options (also known as value) to the lower array, like DocumentArrayPath

mongoose/lib/schema/array.js

Line 455 in 0ddb0f6

SchemaArray.prototype.discriminator = function(name, schema) {

mongoose/lib/schema/documentarray.js

Line 192 in 0ddb0f6

DocumentArrayPath.prototype.discriminator = function(name, schema, options) {

[hasezoey]

@vkarpov15 why was this closed again? from what i can tell the master branch (by extension 7.x) does not yet have the changes done for 6.x for this fix

(also from what i can tell branch 7.1 also does not have a merge of 6.x yet)

[vkarpov15]

@hasezoey I just merged 6.x into main, thanks for pointing this out 👍