types(schema): avoid circular constraint in TSchemaOptions with --incremental by deferring ResolveSchemaOptions<>
#13291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remental by deferring `ResolveSchemaOptions<>` Fix #13129
hasezoey
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13129
Summary
Looks like the
Omit<>trick we did to avoid TS complaining about circular constraints doesn't work if you set theincrementaloption in TypeScript 4.9+. With this changeTSchemaOptionsno longer references itself, so no more circular constraints. We just wrapTSchemaOptionsinResolveSchemaOptionswhenever we use it in the schema class.I wish there was some reasonable way to test this, but the issue doesn't seem to show up in tsd, so our only option would be to manually run a particular version of tsc with
--incrementalon a script. And I don't think that's necessary, seems easy enough to eyeball that this particular change removes the circular constraint.Examples