Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use collection.findOne() for saving docs with no changes #13298

Merged
merged 2 commits into from Apr 20, 2023
Merged

Use collection.findOne() for saving docs with no changes #13298

merged 2 commits into from Apr 20, 2023

Conversation

IslandRhythms
Copy link
Collaborator

closes #13250

@IslandRhythms
use collection.findOne() instead of exists
ba9d74b 
Handles case where `save()` is called on a document with no changes. This prevents the `findOne` hook from running
@IslandRhythms
remove conflicting test
108215b 
since we are implementing a fix that removes exist, this test serves no purpose
@IslandRhythms IslandRhythms self-assigned this Apr 19, 2023
vkarpov15
vkarpov15 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.0.5 milestone Apr 20, 2023
@vkarpov15 vkarpov15 merged commit 94e9d5c into master Apr 20, 2023
34 checks passed
@vkarpov15 vkarpov15 deleted the IslandRhythms/gh-13250 branch April 20, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

@IslandRhythms IslandRhythms

Labels
None yet
Projects
None yet
Milestone
7.0.5
Development

Successfully merging this pull request may close these issues.

Saving a doc without modification triggers post findOne with a pojo
2 participants
@IslandRhythms @vkarpov15