Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(subdocs): fix mention of subdocument ".remove" function #13312

Merged
merged 1 commit into from Apr 24, 2023
Merged

docs(subdocs): fix mention of subdocument ".remove" function #13312

merged 1 commit into from Apr 24, 2023

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR updates the section Removing Subdocs in subdocs.md to use deleteOne instead of remove, because for 7.0 the remove function was renamed deleteOne

fix #13297

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Apr 22, 2023
vkarpov15
vkarpov15 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Looks like I also fixed this in #13316 .

@vkarpov15 vkarpov15 added this to the 7.0.5 milestone Apr 24, 2023
@vkarpov15 vkarpov15 merged commit 8313e60 into Automattic:master Apr 24, 2023
1 check passed
@hasezoey hasezoey deleted the fix13297 branch April 24, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
7.0.5
Development

Successfully merging this pull request may close these issues.

Docs Issue: subdoc remove function not listed in the api
2 participants
@hasezoey @vkarpov15