Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): correctly handle uuids with populate() #13317

Merged
merged 3 commits into from Apr 24, 2023
Merged

fix(schema): correctly handle uuids with populate() #13317

merged 3 commits into from Apr 24, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13267

Summary

Couple of fixes to make UUIDs work better with populate:

  1. Make uuid getter avoid trying to transform populated docs into strings
  2. Avoid trying to cast UUIDs as populated docs

Examples

AbdelrahmanHafez
AbdelrahmanHafez approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

hasezoey
hasezoey approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor additions

test/schema.uuid.test.js Outdated Show resolved Hide resolved
test/schema.uuid.test.js Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 3ecf06a into master Apr 24, 2023
33 checks passed
@hasezoey hasezoey deleted the vkarpov15/uuid-populate-fixes branch April 24, 2023 16:38
@martyzz1
Copy link

Is there any chance of getting this patched into the v6 branch?

@vkarpov15 vkarpov15 mentioned this pull request Jul 10, 2023
Closed
2 tasks
vkarpov15 added a commit that referenced this pull request Jul 11, 2023
@vkarpov15
fix(schema): correctly handle uuids with populate()
9616af7 
Backport #13317
Fix #13595
vkarpov15 added a commit that referenced this pull request Jul 11, 2023
@vkarpov15
test: fix tests re: #13317
4f264a8
@hxtree hxtree mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary UUID is not recognize as Bson Type when need to be cast
4 participants
@vkarpov15 @martyzz1 @hasezoey @AbdelrahmanHafez