Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website sidebar to be better use-able #13321

Merged
merged 7 commits into from Apr 25, 2023

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR (mainly) updates the documentation side-bar to be better use-able, things include:

  • replace span hamburger menu-hack with a svg
  • change the container element for #menu > .pure-menu to be a nav instead of implicit div
  • change sub-lists to be their own lists (plus css changes necessary)
  • show indications of what element in the side-bar is currently hovered over (and use the same effect for the current page)
  • change the mobile-menu (logo) header and sidebar to be sticky / fixed, so it can be accessed at any scroll level

re #13314

Screenshots

old active & hover:
original_active_and_hover

new active & hover:
new_active_and_hover

old mobile + scroll:
orig_mobile

new mobile + scroll:
new_mobile

PS: these changes should make it easier to change the lists (secondary & tertiary lists) to be made collapsible

PPS: these changes also work great with things like dark-reader

@hasezoey hasezoey added docs This issue is due to a mistake or omission in the mongoosejs.com documentation enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature labels Apr 24, 2023
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.1.0 milestone Apr 25, 2023
@vkarpov15 vkarpov15 merged commit fabc695 into Automattic:master Apr 25, 2023
1 check passed
@hasezoey hasezoey deleted the updateSidebar branch April 25, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants