types(query): make `lean()` flatten out inferred maps into Record<string, V> #13326

vkarpov15 · 2023-04-25T01:43:34Z

Summary

lean() queries never return maps, because Mongoose maps are stored as POJOs in MongoDB. This PR makes so that lean() uses FlattenMaps by default to replace maps in documents with their Record<> equivalent.

Examples

…ing, V> Fix #13010

hasezoey

LGTM, aside from one question

package.json

types(query): make lean() flatten out inferred maps into Record<str…

3048e89

…ing, V> Fix #13010

vkarpov15 requested review from Uzlopak, hasezoey and AbdelrahmanHafez April 25, 2023 01:43

hasezoey approved these changes Apr 25, 2023

View reviewed changes

package.json Show resolved Hide resolved

vkarpov15 merged commit 881c5ab into 7.1 Apr 25, 2023
36 checks passed

hasezoey deleted the vkarpov15/gh-13010 branch April 25, 2023 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

types(query): make `lean()` flatten out inferred maps into Record<string, V> #13326

types(query): make `lean()` flatten out inferred maps into Record<string, V> #13326

vkarpov15 commented Apr 25, 2023

hasezoey left a comment

types(query): make lean() flatten out inferred maps into Record<string, V> #13326

types(query): make lean() flatten out inferred maps into Record<string, V> #13326

Conversation

vkarpov15 commented Apr 25, 2023

hasezoey left a comment

Choose a reason for hiding this comment

types(query): make `lean()` flatten out inferred maps into Record<string, V> #13326

types(query): make `lean()` flatten out inferred maps into Record<string, V> #13326