Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't modify passed options object #13376

Merged
merged 7 commits into from May 4, 2023
Merged

fix: don't modify passed options object #13376

merged 7 commits into from May 4, 2023

Conversation

IslandRhythms
Copy link
Collaborator

closes #13335

@IslandRhythms IslandRhythms self-assigned this May 3, 2023
@IslandRhythms
Copy link
Collaborator Author

I'm not sure what exactly is timing out. The test passes on my machine.

Uzlopak
Uzlopak reviewed May 3, 2023
View reviewed changes
test/connection.test.js Outdated Show resolved Hide resolved
vkarpov15
vkarpov15 requested changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change but otherwise LGTM.

Also, can you please remove the logic in lib/connection.js that calls clone(options) right after calling processConnectionOptions()?

test/connection.test.js Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 8305821 into master May 4, 2023
33 of 34 checks passed
@hasezoey hasezoey deleted the IslandRhythms/gh-13335 branch May 19, 2023 16:50
vkarpov15 pushed a commit that referenced this pull request Feb 25, 2024
@IslandRhythms @vkarpov15
test: fix issues with cherry-picking #13376 to 6.x
5dfb62f
@vkarpov15 vkarpov15 mentioned this pull request Feb 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

@IslandRhythms IslandRhythms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

options object get mutated
3 participants
@IslandRhythms @vkarpov15 @Uzlopak