feat(query): add translateAliases option to automatically call translate aliases on query fields
#13397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
hasezoey
requested changes
May 13, 2023
There was a problem hiding this comment.
looks good to me, though there are some thing that should still be done:
- test if the alias takes priority or errors if both are defined at the same time in the query
- test if the alias has any effect if the alias is used in a query but the actual property in a update (or vise-versa)
- document the above behavior somewhere on the documentation
also i dont know how feasible it is, but maybe consider calling _applyTranslateAliases in _optionsForExec?
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: Hafez <a.hafez852@gmail.com>
hasezoey
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7511
Fix #8678
Summary
Add
translateAliasesoption on query, schema, and global level to applyModel.translateAliases()on all query fields automatically:filter,projection,update, anddistinct.Examples