Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add virtuals schema options #13407

Merged
merged 3 commits into from May 18, 2023
Merged

[docs] Add virtuals schema options #13407

merged 3 commits into from May 18, 2023

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR mentions option virtuals as possible schema-option, also adds a entry for definition in the tutorials/virtuals guide (re-using existing code)

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label May 17, 2023
AbdelrahmanHafez
AbdelrahmanHafez approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

vkarpov15
vkarpov15 approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.1.2 milestone May 18, 2023
@vkarpov15 vkarpov15 merged commit 7fee2dd into Automattic:master May 18, 2023
18 of 19 checks passed
@hasezoey hasezoey deleted the addVirtualsSchemaOptions branch May 18, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
7.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hasezoey @vkarpov15 @AbdelrahmanHafez