Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(connections): add details about keepAlive deprecation #13431

Merged
merged 1 commit into from May 23, 2023

Conversation

vkarpov15
Copy link
Collaborator

Re: #13391

Summary

Quick note about keepAlive deprecation in the most recent release of the MongoDB Node driver. Related reading: https://www.mongodb.com/docs/v7.0/faq/diagnostics/#does-tcp-keepalive-time-affect-mongodb-deployments-, https://jira.mongodb.org/browse/NODE-5190

Examples

@vkarpov15 vkarpov15 added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label May 23, 2023
@vkarpov15 vkarpov15 added this to the 7.2.1 milestone May 23, 2023
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@vkarpov15 vkarpov15 merged commit 8263a53 into master May 23, 2023
1 check passed
@hasezoey hasezoey deleted the vkarpov15/gh-13391 branch May 24, 2023 08:22

`keepAliveInitialDelay` is the number of milliseconds to wait before initiating `keepAlive` on the socket.
`keepAlive` is true by default since mongoose 5.2.0.
Before Mongoose 5.2.0, you needed to enable the `keepAlive` option to initiate [TCP keepalive](https://tldp.org/HOWTO/TCP-Keepalive-HOWTO/overview.html) to prevent `"connection closed"` errors errors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think double "errors" is not quite right here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants