Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove callback based examples #13433

Merged
merged 4 commits into from May 24, 2023
Merged

Conversation

IslandRhythms
Copy link
Collaborator

closes #13401

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, though i noticed some things

docs/connections.md Outdated Show resolved Hide resolved
docs/queries.md Outdated Show resolved Hide resolved
Co-authored-by: hasezoey <hasezoey@gmail.com>
docs/queries.md Outdated
@@ -93,7 +82,7 @@ Person.
limit(10).
sort({ occupation: -1 }).
select({ name: 1, occupation: 1 }).
exec(callback);
exec();

// Using query builder
Person.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add await here

docs/connections.md Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 0e08bb2 into master May 24, 2023
1 check passed
@vkarpov15 vkarpov15 deleted the IslandRhythms/fix-callback-docs branch May 24, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query documentation still suggests unsupported method
3 participants