fix(cursor): handle calling skipMiddlewareFunction() in pre('find') middleware with cursors
#13436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… middleware with cursors Fix #13411
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
IslandRhythms
approved these changes
May 24, 2023
hasezoey
reviewed
May 25, 2023
vkarpov15
added a commit
that referenced
this pull request
May 25, 2023
vkarpov15
added a commit
that referenced
this pull request
May 26, 2023
refactor(cursor): use arrow functions instead of `_this` throughout
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13411
Summary
Currently,
skipMiddlewareFunction()inpre('find')middleware causes an error if you're using cursors. With this change, it is now fine to callskipMiddlewareFunction()in pre('find') middleware with cursors with no parameters; or withnull,undefined, or empty array[].The reason why we don't support passing an array of documents is that it would be tricky to rewrite current cursor logic to use arrays. We may consider this for the future if there's demand.
Examples