fix(query): handle plus path in projection with findOneAndUpdate() #13437
+34
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
|
Does Edit: I'm guessing |
|
Yep "+" means "this field is excluded by default, don't exclude it for this operation". |
vkarpov15
added a commit
that referenced
this pull request
May 25, 2023
AbdelrahmanHafez
added a commit
that referenced
this pull request
May 25, 2023
test(findOneAndUpdate): add extra assertions from code review for #13437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13413
Summary
Looks like we double applied paths in
findOneAndUpdate(). Likely due to merge conflict issues with 6.x. Cleaned that up and added a test, so shouldn't happen again.Examples