Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: improve function parameter types for ToObjectOptions transform option #13446

Merged
merged 1 commit into from May 27, 2023
Merged

types: improve function parameter types for ToObjectOptions transform option #13446

merged 1 commit into from May 27, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13421

Summary

So the parameters aren't all any

Examples

hasezoey
hasezoey approved these changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe consider adding a types test so that it does not get lost

@vkarpov15 vkarpov15 merged commit f9e8544 into master May 27, 2023
3 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13421 branch May 27, 2023 18:59
@hasezoey hasezoey mentioned this pull request Jun 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arguments' types of the transform function should be improved.
2 participants
@vkarpov15 @hasezoey