docs(connections): add section on multi tenant #13449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
hasezoey
approved these changes
May 28, 2023
| const express = require('express'); | ||
| const mongoose = require('mongoose'); | ||
|
|
||
| mongoose.connect('mongodb://127.0.0.1:27017/main'); |
There was a problem hiding this comment.
is this still required here?
There was a problem hiding this comment.
Yes, to highlight that you do still need to connect before using useDb().
There was a problem hiding this comment.
from what i can tell, this code example does not use useDb, and rather createConnection and never the default connection itself
There was a problem hiding this comment.
That's a fair point, this mongoose.connect() call could be confusing. I put it here because in a multi-tenant scenario you may use the default connection to look up tenants. But not necessarily, so we can remove that.
Co-authored-by: hasezoey <hasezoey@gmail.com>
vkarpov15
added a commit
that referenced
this pull request
Jun 2, 2023
docs(connections): remove unnecessary mongoose.connect() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11187
Summary
We get lots of questions about multi tenant, so would be nice to have a section of the docs to point people to.
Examples