fix: Document.prototype.isModified support for a string of keys as first parameter #13674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastoncasini
changed the title
gastoncasini
changed the title
gastoncasini
changed the title
2 tasks
vkarpov15
added a commit
that referenced
this pull request
Oct 8, 2023
…t-string-of-keys Backport document.isModified fix #13674 to 6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request should fix the issue #13667.
The error was caused in a recent change of the Document.isModified method, to resolve it I returned the paths variable declaration as it was before that change.
Examples
These pictures show the repro script provided in the original issue running with and without the changes