types(model): support calling Model.validate() with pathsToSkip option
#14088
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
reviewed
Nov 17, 2023
Comment on lines
463
to
+466
| validate(): Promise<void>; | ||
| validate(optional: any): Promise<void>; | ||
| validate(optional: any, pathsToValidate: PathsToValidate): Promise<void>; | ||
| validate(obj: any): Promise<void>; | ||
| validate(obj: any, pathsOrOptions: PathsToValidate): Promise<void>; | ||
| validate(obj: any, pathsOrOptions: { pathsToSkip?: pathsToSkip }): Promise<void>; |
There was a problem hiding this comment.
kinda unrelated to this PR or issue, but dosnt validate return a casted copy?
Line 3992 in 72b4094
hasezoey
approved these changes
Nov 17, 2023
AbdelrahmanHafez
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #14003
Summary
While #14003 looks like a non-issue, it did lead us to find that TS types don't support calling
Model.validate()with apathsToSkipoptionExamples