Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(populate): fix curPath to update appropriately #14099

Merged
merged 5 commits into from Nov 19, 2023

Conversation

csy1204
Copy link
Contributor

@csy1204 csy1204 commented Nov 19, 2023

Summary

Fixes this issue: #14098

Examples

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll make a quick refactor in master to avoid string concatenation in cases where not necessary, but looks good overall.

@vkarpov15 vkarpov15 added this to the 8.0.2 milestone Nov 19, 2023
@vkarpov15 vkarpov15 merged commit 07dba1b into Automattic:master Nov 19, 2023
18 checks passed
@csy1204
Copy link
Contributor Author

csy1204 commented Nov 20, 2023

@vkarpov15
Thank you for your approval!
I'd like to ask, could this be included in 7.6.6? Because my team would like to include it in the next deployment, but it's hard to upgrade straight to 8.0.2 due to the breaking changes in 8.0.

@csy1204 csy1204 deleted the fix/gh-14098 branch November 20, 2023 02:47
@vkarpov15
Copy link
Collaborator

@csy1204 yeah sure, we will cherry pick this to 7.6.6 as well

vkarpov15 added a commit that referenced this pull request Nov 22, 2023
fix(populate): fix curPath to update appropriately
@vkarpov15
Copy link
Collaborator

Cherry picked in a848de0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants