Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(document): correct return type for doc.deleteOne() re: Mongoose 8 breaking change #14110

Merged
merged 1 commit into from Nov 22, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #14081

Summary

TypeScript types for doc.deleteOne() still return Promise<this>. This PR makes doc.deleteOne() correctly return a QueryWithHelpers with correct types.

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Nov 22, 2023
@vkarpov15 vkarpov15 merged commit 3e0a90c into master Nov 22, 2023
3 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14081 branch November 22, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect return type in Typescript for doc.deleteOne() in v8
2 participants